Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cluster-level Monte Carlo FWE correction in the MKDAChi2 Estimator #650

Merged
merged 19 commits into from
Mar 2, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 26, 2022

Closes None.

Changes proposed in this pull request:

  • Implement cluster-level FWE correction in the MKDAChi2 estimator.
  • Fix voxel-level FWE correction in the MKDAChi2 estimator.
    • It looks like the FWE null distributions really shouldn't be treated as two-sided tests, which is how the vFWE was being done. The FWE null distribution reflect maximum values across both negative and positive values/clusters, so we need to take the absolute values and compare those in a one-sided way to the null distributions before re-signing them.

@tsalo tsalo added enhancement New feature or request cbma Issues/PRs pertaining to coordinate-based meta-analysis labels Feb 26, 2022
@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #650 (874bff6) into main (02387b9) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   85.02%   85.24%   +0.22%     
==========================================
  Files          40       40              
  Lines        4460     4528      +68     
==========================================
+ Hits         3792     3860      +68     
  Misses        668      668              
Impacted Files Coverage Δ
nimare/meta/cbma/base.py 94.94% <100.00%> (+0.22%) ⬆️
nimare/meta/cbma/mkda.py 97.09% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02387b9...874bff6. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented Mar 2, 2022

For some reason the threshold parameter isn't having any effect on the plot_stat_map figures, but I don't think it's a problem for the new feature.

@tsalo tsalo merged commit b2ee236 into neurostuff:main Mar 2, 2022
@tsalo tsalo deleted the mkdachi2-cfwe branch March 2, 2022 23:09
@tsalo
Copy link
Member Author

tsalo commented Mar 21, 2022

I may have to revisit this based on #655 (comment). Now in #663.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cbma Issues/PRs pertaining to coordinate-based meta-analysis enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant