Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MA map pre-generation in CorrelationDecoder #637

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 12, 2022

Closes None, but should help many users. Per #629 and #630, storing the MA maps as files and loading them as needed actually slows things down and increases memory usage, which could, at least in part, explain why CorrelationDecoder is so unusable for users.

Changes proposed in this pull request:

  • Do not pre-generate MA maps for the CorrelationDecoder.
  • Also, use tqdm to track the decoder's fit progress.

Per neurostuff#629 and neurostuff#630, this actually slows things down and increases memory usage.
@tsalo tsalo added decode Issues related to the decode module refactoring Requesting changes to the code which do not impact behavior labels Feb 12, 2022
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #637 (636a7c5) into main (c35ca9b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   87.89%   87.86%   -0.03%     
==========================================
  Files          40       40              
  Lines        4320     4319       -1     
==========================================
- Hits         3797     3795       -2     
- Misses        523      524       +1     
Impacted Files Coverage Δ
nimare/decode/continuous.py 94.94% <100.00%> (-0.06%) ⬇️
nimare/meta/kernel.py 96.51% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35ca9b...636a7c5. Read the comment docs.

@tsalo tsalo merged commit f8ed7e7 into neurostuff:main Feb 18, 2022
@tsalo tsalo deleted the corrdecoder-improvements branch February 18, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decode Issues related to the decode module refactoring Requesting changes to the code which do not impact behavior
Projects
Development

Successfully merging this pull request may close these issues.

1 participant