Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce SCALE memory usage #632

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 8, 2022

Closes None, but is related to NBCLab/nimare-paper#21.

Changes proposed in this pull request:

  • Loop over voxels when calculating p-values from SCALE null distributions, rather than keeping the full arrays in memory.

@tsalo tsalo added refactoring Requesting changes to the code which do not impact behavior cbma Issues/PRs pertaining to coordinate-based meta-analysis labels Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #632 (b89d06f) into main (7e094f2) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   87.53%   87.89%   +0.35%     
==========================================
  Files          40       40              
  Lines        4316     4319       +3     
==========================================
+ Hits         3778     3796      +18     
+ Misses        538      523      -15     
Impacted Files Coverage Δ
nimare/meta/cbma/ale.py 94.14% <100.00%> (+0.09%) ⬆️
nimare/meta/utils.py 88.70% <100.00%> (ø)
nimare/stats.py 94.23% <100.00%> (ø)
nimare/transforms.py 75.36% <100.00%> (ø)
nimare/utils.py 95.46% <100.00%> (ø)
nimare/diagnostics.py 95.40% <0.00%> (+17.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e094f2...b89d06f. Read the comment docs.

@tsalo tsalo merged commit 0c67c5e into neurostuff:main Feb 8, 2022
@tsalo tsalo deleted the reduce-scale-memory branch February 8, 2022 22:16
@tsalo tsalo changed the title [REF] Reduce SCALE memory usage Reduce SCALE memory usage Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cbma Issues/PRs pertaining to coordinate-based meta-analysis refactoring Requesting changes to the code which do not impact behavior
Projects
Development

Successfully merging this pull request may close these issues.

1 participant