Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmpdir for memmap files instead of the NiMARE data directory #599

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 5, 2021

Closes #569, but I still want to look into nilearn's approach to memory management. This PR reverts parts of #460, and I'm hoping there won't be problems with the NiMARE manuscript code.

This mostly spun out from #597 as I figured it would help there as well.

Changes proposed in this pull request:

  • Use default temporary directory for memmap files instead of NiMARE data directory.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #599 (79204a7) into main (bdcec80) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.01%     
==========================================
  Files          40       40              
  Lines        4382     4380       -2     
==========================================
- Hits         3757     3755       -2     
  Misses        625      625              
Impacted Files Coverage Δ
nimare/utils.py 94.25% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdcec80...79204a7. Read the comment docs.

@tsalo tsalo added the refactoring Requesting changes to the code which do not impact behavior label Nov 6, 2021
@tsalo tsalo requested a review from JulioAPeraza November 6, 2021 17:56
@tsalo tsalo changed the title [REF] Use tmpdir for memmaps Use tmpdir for memmap files instead of the NiMARE data directory Dec 14, 2021
@tsalo
Copy link
Member Author

tsalo commented Jan 5, 2022

I'm going to bite the bullet and merge this. Hopefully it won't cause problems for the Jupyter book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Requesting changes to the code which do not impact behavior
Projects
Development

Successfully merging this pull request may close these issues.

Use temporary directory for memory-mapped files
2 participants