Skip to content

Use nilearn masker memory parameters instead of safe_transform #598

Open
@tsalo

Description

@tsalo

Summary

The nilearn masker objects have memory and memory_level parameters. I don't have much experience with them, but I think they could be used as an alternative to our safe_transform function (added in #520).

Additional details

Hopefully, this would reduce NiMARE's burden and simplify our code. I'm also hoping that nilearn's approach would handle large arrays more easily than our own.

Next steps

  1. On a branch, replace safe_transform with simple Masker.transform calls, but initialize or set params in the maskers to use the memory parameters.
  2. Memory profile our current code against the branch's approach.

Metadata

Metadata

Assignees

Labels

opinions wantedA discussion item for which opinions would be appreciated.refactoringRequesting changes to the code which do not impact behavior

Type

No type

Projects

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions