fix: memoization

neurosnap · Sep 15, 2023 · 86c6b72 · 86c6b72
1 parent a408d74
commit 86c6b72
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/create-loader-table.ts b/src/create-loader-table.ts
@@ -81,13 +81,13 @@ export function loaderTableSelectors<S = any>(
 
   const selectById: any = createSelector(
     selectTable,
-    (s: S, p: PropId) => p,
-    findById,
+    (_: S, p: PropId) => p.id,
+    (loaders, id) => findById(loaders, { id }),
   );
   const selectByIds: any = createSelector(
     selectTable,
-    (s: S, p: PropIds) => p,
-    findByIds,
+    (_: S, p: PropIds) => p.ids,
+    (loaders, ids) => findByIds(loaders, { ids }),
   );
 
   return {

diff --git a/src/create-table.ts b/src/create-table.ts
@@ -44,8 +44,8 @@ export function tableSelectors<Entity extends AnyState = AnyState, S = any>(
     selectById,
     selectByIds: createSelector(
       selectTable,
-      (s: S, p: PropIds) => p,
-      findByIds,
+      (_: S, p: PropIds) => p.ids,
+      (tbl, ids) => findByIds(tbl, { ids }),
     ) as any,
   };
 }