Skip to content

Conversation

@kristianbinau
Copy link

Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ”§ Improvement/Enhancement (non-breaking change which improves existing functionality)
  • πŸ“– Documentation update
  • 🧹 Code cleanup/refactoring (no functional changes)
  • ⚑ Performance improvement
  • πŸ”’ Security fix

Description

What does this PR do?

Fix an error in RetrieveDocumentsNode, where it would emit the wrong data for rag-retrieved

Why is this change needed?

This would always break on RAG messages in v3

Testing

  • I have tested this change locally
  • I have added/updated unit tests where appropriate
  • All existing tests pass
  • I have tested this with different PHP versions (if applicable)

Breaking Changes

  • No breaking changes
  • Yes, this PR introduces breaking changes (explain below)

Documentation

  • No documentation changes needed
  • I have updated relevant documentation
  • Documentation will be updated in a separate PR
  • New documentation needs to be created

Checklist

  • My code follows the project's coding standards (PHPStan)
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • My commit messages are clear and descriptive
  • This PR addresses only ONE specific goal/issue

Additional Notes

Any additional information, concerns, or questions for reviewers

Was emitting Events\Retrieving, which produced an exception.
@ilvalerione ilvalerione merged commit fa09ce9 into neuron-core:3.x Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants