Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check container status on attach #372

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Apr 1, 2021

No description provided.

@romasku romasku requested a review from zubenkoivan April 1, 2021 15:16
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #372 (ea365d7) into master (89e637b) will decrease coverage by 0.06%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   90.43%   90.36%   -0.07%     
==========================================
  Files          11       11              
  Lines        1505     1516      +11     
  Branches      165      169       +4     
==========================================
+ Hits         1361     1370       +9     
- Misses        111      112       +1     
- Partials       33       34       +1     
Flag Coverage Δ
integration 84.23% <92.30%> (-0.02%) ⬇️
unit 51.84% <0.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
platform_monitoring/api.py 79.30% <80.00%> (+0.13%) ⬆️
platform_monitoring/jobs_service.py 97.88% <100.00%> (+0.09%) ⬆️
platform_monitoring/kube_client.py 93.10% <0.00%> (-0.58%) ⬇️

@romasku romasku merged commit cbea24a into master Apr 9, 2021
@romasku romasku deleted the rs/check-container-on-attach branch April 9, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants