Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding corey-nm to .MAINTAINERS #945

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Adding corey-nm to .MAINTAINERS #945

merged 1 commit into from
Jul 18, 2022

Conversation

corey-nm
Copy link
Contributor

🎉

@github-actions github-actions bot requested a review from rahul-tuli July 18, 2022 17:50
@github-actions
Copy link

@rahul-tuli assigned for review

@bfineran
Copy link
Contributor

@corey-nm please re-title to third person.
Also please be sure to squash and merge

@corey-nm corey-nm changed the title Adding myself to .MAINTAINERS Adding corey-nm to .MAINTAINERS Jul 18, 2022
@corey-nm
Copy link
Contributor Author

@corey-nm please re-title to third person. Also please be sure to squash and merge

Want me to change commit messge as well?

@bfineran
Copy link
Contributor

@corey-nm please re-title to third person. Also please be sure to squash and merge

Want me to change commit messge as well?

no, that's ok

@corey-nm corey-nm merged commit f1df449 into main Jul 18, 2022
@corey-nm corey-nm deleted the add-corey-to-maintainers branch July 18, 2022 18:04
@rahul-tuli
Copy link
Member

Yay! congrats on your first PR @corey-nm 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@KSGulin KSGulin KSGulin approved these changes

@rahul-tuli rahul-tuli Awaiting requested review from rahul-tuli

Assignees

@corey-nm corey-nm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corey-nm @bfineran @rahul-tuli @KSGulin