[Fix] Handlers being unnecessarily created for logger #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
force-pushed
the
fix/damian/logers
branch
from
4fb28ef
to
58c5bf2
Compare
dbogunowicz
changed the title
dbogunowicz
dismissed stale reviews from rahul-tuli and corey-nm
The base branch was changed.
dbogunowicz
commented
Mar 27, 2023
corey-nm
previously approved these changes
Mar 27, 2023
KSGulin
approved these changes
Mar 27, 2023
rahul-tuli
approved these changes
Mar 27, 2023
corey-nm
approved these changes
Mar 27, 2023
bfineran
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that I noticed recently: loggers were creating too many handlers and thus logging the same information multiple times. We paired programmed with Konstantin to fix that.