This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekk-nm
requested review from
dbarbuzzi,
dhuangnm,
andy-neuma and
robertgshaw2-neuralmagic
May 30, 2024 14:41
andy-neuma
reviewed
May 31, 2024
Add a test case to verify that the expected licenses are included in the package distribution location.
refactored identifying dist-info path to skip local installs. clarifying comment updates.
dbarbuzzi
reviewed
Jun 4, 2024
run-tests should only attempt to download buildkite images if the bash file can be found. This allows the script to execute tests from neuralmagic/tests.
instead of using run_tests
andy-neuma
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. thanks.
the one job that failed has test case failures that are issues under investigation.
The license tests ran, and reported as passed:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case to verify that the expected licenses are included in the package distribution location.