Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

[CI/Build] Verify licenses #272

Merged
merged 10 commits into from
Jun 5, 2024
Merged

[CI/Build] Verify licenses #272

merged 10 commits into from
Jun 5, 2024

Conversation

derekk-nm
Copy link

Add a test case to verify that the expected licenses are included in the package distribution location.

@derekk-nm derekk-nm marked this pull request as ready for review May 30, 2024 14:41
neuralmagic/tests/test_nm-vllm_licenses.py Outdated Show resolved Hide resolved
neuralmagic/tests/test_nm-vllm_licenses.py Outdated Show resolved Hide resolved
neuralmagic/tests/test_nm-vllm_licenses.py Outdated Show resolved Hide resolved
neuralmagic/tests/test_nm-vllm_licenses.py Show resolved Hide resolved
neuralmagic/tests/test_nm-vllm_licenses.py Outdated Show resolved Hide resolved
Add a test case to verify that the expected licenses are included in the package distribution location.
refactored identifying dist-info path to skip local installs.  clarifying comment updates.
run-tests should only attempt to download buildkite images if the bash file can be found.  This allows the script to execute tests from neuralmagic/tests.
instead of using run_tests
Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. thanks.

@derekk-nm
Copy link
Author

the one job that failed has test case failures that are issues under investigation.

=========================== short test summary info ============================
FAILED tests/models/test_gptq_marlin.py::test_models[5-32-half-model1] - AssertionError: Test1:
gptq:	'Briefly describe the major milestones in the development of artificial intelligence from 1950 to 2020. What are the major'
gptq_marlin:	'Briefly describe the major milestones in the development of artificial intelligence from 1950 to 2020. (10 points'
FAILED tests/models/test_gptq_marlin.py::test_models[5-32-bfloat16-model1] - AssertionError: Test3:
gptq:	'Describe the basic components of a neural network and how it can be trained. Neural networks are a type of machine learning algorithm that is inspired by the human'
gptq_marlin:	'Describe the basic components of a neural network and how it can be trained. (a) A neural network is a computational model that is inspired by the bi'
======== 2 failed, 14 passed, 22 warnings, 6 rerun in 472.43s (0:07:52) ========

The license tests ran, and reported as passed:

platform linux -- Python 3.8.17, pytest-8.2.2, pluggy-1.5.0
rootdir: /opt/actions-runner/_work/nm-vllm/nm-vllm
configfile: pyproject.toml
plugins: cov-5.0.0, forked-1.6.0, asyncio-0.23.7, anyio-4.4.0, shard-0.1.2, xdist-3.6.1, rerunfailures-14.0
asyncio: mode=strict
collected 13 items
Running 13 items in this shard

neuralmagic/tests/test_nm-vllm_licenses.py .............                 [100%]

- generated xml file: /opt/actions-runner/_work/nm-vllm/nm-vllm/test-results/test_nm-vllm_licenses.xml -
============================== 13 passed in 2.92s ==============================

@andy-neuma andy-neuma merged commit fd663dc into main Jun 5, 2024
12 checks passed
@andy-neuma andy-neuma deleted the License_check branch June 5, 2024 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants