This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Benchmark : Fix remote push job #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-sundar-rabindranath
force-pushed
the
varun/fix-remote-push
branch
2 times, most recently
from
d6e8aae
to
481e2e8
Compare
varun-sundar-rabindranath
requested review from
mgoin and
robertgshaw2-neuralmagic
varun-sundar-rabindranath
force-pushed
the
varun/fix-remote-push
branch
from
481e2e8
to
0610937
Compare
robertgshaw2-neuralmagic
approved these changes
Mar 26, 2024
varun-sundar-rabindranath
force-pushed
the
varun/fix-remote-push
branch
from
0610937
to
c1d3e2a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
github-action-benchmarkaction, needs a JSON file with metrics for reporting. It throws an error when the JSON is empty or doesn't have any data.Bug: On the
remote pushbenchmark job, we produce the necessary files, but they don't have any JSON data.Fix: Make the logging script skip file creation if the file is going to be empty. In the GHA side, add logic to skip processing when a desired file does not exist.
Additional changes:
GHABenchmarkToolName->BenchmarkMetricTypeObservationBenchmarkMetricType - This could be useful in the near future when we discover volatile metrics.TEST PLAN:
Jobs on this PR.