Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Commit

Permalink
Fix docker build failure in nighlty (#364)
Browse files Browse the repository at this point in the history
Fixed two issues:

1. Trigger nm pypi update workflow in stratus automatically after wheels
are uploaded to GCP.
2. Docker build step should only run after the upload step is finished
successfully.

An example run from nm-vllm:
https://github.com/neuralmagic/nm-vllm/actions/runs/9810788569

which triggers stratus nm pypi update workflow run:
https://github.com/neuralmagic/stratus/actions/runs/9810806638

---------

Co-authored-by: dhuangnm <dhuang@MacBook-Pro-2.local>
  • Loading branch information
dhuangnm and dhuangnm authored Jul 8, 2024
1 parent f6f2554 commit 537957c
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/nm-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ jobs:

# update docker
DOCKER:
needs: [BUILD]
needs: [BUILD, UPLOAD]
if: ${{ inputs.wf_category != 'REMOTE' }}
uses: ./.github/workflows/publish-docker.yml
with:
Expand Down
28 changes: 28 additions & 0 deletions .github/workflows/nm-upload-assets-to-gcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@ on:
type: string
required: true

workflow_dispatch:
inputs:
label:
description: "requested runner label (specifies instance)"
type: string
required: true
timeout:
description: "time limit for run in minutes "
type: string
required: true
gitref:
description: 'git commit hash or branch name'
type: string
required: true

jobs:

PUBLISH:
Expand Down Expand Up @@ -70,3 +85,16 @@ jobs:
- name: cp assets
id: cp-assets
uses: ./.github/actions/nm-cp-assets/

- name: trigger stratus nm-pypi update workflow to update nm-pypi index
uses: actions/github-script@v6
with:
github-token: ${{ secrets.CICD_GITHUB_PAT }}
script: |
const result = await github.rest.actions.createWorkflowDispatch({
owner: 'neuralmagic',
repo: 'stratus',
workflow_id: 'nm-pypi-update.yml',
ref: 'main'
})
console.log(result)

1 comment on commit 537957c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smaller_is_better

Benchmark suite Current: 537957c Previous: f6f2554 Ratio
{"name": "mean_ttft_ms", "description": "VLLM Serving - Dense\nmodel - facebook/opt-350m\nmax-model-len - 2048\nsparsity - None\nbenchmark_serving {\n \"nr-qps-pair_\": \"300,1\",\n \"dataset\": \"sharegpt\"\n}", "gpu_description": "NVIDIA L4 x 1", "vllm_version": "0.5.1", "python_version": "3.10.12 (main, Jun 7 2023, 13:43:11) [GCC 11.3.0]", "torch_version": "2.3.0+cu121"} 23.563603496677388 ms 24.363126653334653 ms 0.97
{"name": "mean_tpot_ms", "description": "VLLM Serving - Dense\nmodel - facebook/opt-350m\nmax-model-len - 2048\nsparsity - None\nbenchmark_serving {\n \"nr-qps-pair_\": \"300,1\",\n \"dataset\": \"sharegpt\"\n}", "gpu_description": "NVIDIA L4 x 1", "vllm_version": "0.5.1", "python_version": "3.10.12 (main, Jun 7 2023, 13:43:11) [GCC 11.3.0]", "torch_version": "2.3.0+cu121"} 5.977048247888172 ms 6.047910136160147 ms 0.99
{"name": "mean_ttft_ms", "description": "VLLM Serving - Dense\nmodel - meta-llama/Meta-Llama-3-8B-Instruct\nmax-model-len - 4096\nsparsity - None\nbenchmark_serving {\n \"nr-qps-pair_\": \"300,1\",\n \"dataset\": \"sharegpt\"\n}", "gpu_description": "NVIDIA L4 x 1", "vllm_version": "0.5.1", "python_version": "3.10.12 (main, Jun 7 2023, 13:43:11) [GCC 11.3.0]", "torch_version": "2.3.0+cu121"} 186.92139306662284 ms 184.3794278033306 ms 1.01
{"name": "mean_tpot_ms", "description": "VLLM Serving - Dense\nmodel - meta-llama/Meta-Llama-3-8B-Instruct\nmax-model-len - 4096\nsparsity - None\nbenchmark_serving {\n \"nr-qps-pair_\": \"300,1\",\n \"dataset\": \"sharegpt\"\n}", "gpu_description": "NVIDIA L4 x 1", "vllm_version": "0.5.1", "python_version": "3.10.12 (main, Jun 7 2023, 13:43:11) [GCC 11.3.0]", "torch_version": "2.3.0+cu121"} 83.59149550139291 ms 85.039470859161 ms 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.