Skip to content

Data and request fixes for real data / chat_completions pathways #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/guidellm/backend/openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,13 @@ async def text_completions( # type: ignore[override]
and a ResponseSummary for the final response.
"""
logger.debug("{} invocation with args: {}", self.__class__.__name__, locals())

if isinstance(prompt, list):
raise ValueError(
"List prompts (batching) is currently not supported for "
f"text_completions OpenAI pathways. Received: {prompt}"
)

headers = self._headers()
payload = self._completions_payload(
orig_kwargs=kwargs,
Expand Down
3 changes: 3 additions & 0 deletions src/guidellm/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ class Settings(BaseSettings):
Literal["request", "response", "local"]
] = "response"
preferred_backend: Literal["openai"] = "openai"
preferred_route: Literal["text_completions", "chat_completions"] = (
"text_completions"
)
openai: OpenAISettings = OpenAISettings()

# Output settings
Expand Down
16 changes: 9 additions & 7 deletions src/guidellm/dataset/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,21 @@ def load_dataset(

dataset = Dataset.from_dict({"text": items}, **(data_args or {}))
elif path.suffix.lower() == ".csv":
dataset = load_dataset("csv", data_files=path, **(data_args or {}))
dataset = load_dataset("csv", data_files=str(path), **(data_args or {}))
elif path.suffix.lower() in {".json", ".jsonl"}:
dataset = load_dataset("json", data_files=path, **(data_args or {}))
dataset = load_dataset("json", data_files=str(path), **(data_args or {}))
elif path.suffix.lower() == ".parquet":
dataset = load_dataset("parquet", data_files=path, **(data_args or {}))
dataset = load_dataset("parquet", data_files=str(path), **(data_args or {}))
elif path.suffix.lower() == ".arrow":
dataset = load_dataset("arrow", data_files=path, **(data_args or {}))
dataset = load_dataset("arrow", data_files=str(path), **(data_args or {}))
elif path.suffix.lower() == ".hdf5":
dataset = Dataset.from_pandas(pd.read_hdf(path), **(data_args or {}))
dataset = Dataset.from_pandas(pd.read_hdf(str(path)), **(data_args or {}))
elif path.suffix.lower() == ".db":
dataset = Dataset.from_sql(con=path, **(data_args or {}))
dataset = Dataset.from_sql(con=str(path), **(data_args or {}))
elif path.suffix.lower() == ".tar":
dataset = load_dataset("webdataset", data_files=path, **(data_args or {}))
dataset = load_dataset(
"webdataset", data_files=str(path), **(data_args or {})
)
else:
raise ValueError(f"Unsupported file type: {path.suffix} given for {path}. ")

Expand Down
5 changes: 4 additions & 1 deletion src/guidellm/request/loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from datasets import Dataset, DatasetDict, IterableDataset, IterableDatasetDict
from transformers import PreTrainedTokenizerBase # type: ignore[import]

from guidellm.config import settings
from guidellm.dataset import ColumnInputTypes, load_dataset
from guidellm.objects import StandardBaseModel
from guidellm.request.request import GenerationRequest
Expand Down Expand Up @@ -61,6 +62,8 @@ class GenerativeRequestLoader(RequestLoader):
"content",
"conversation",
"conversations",
"turn",
"turns",
"text",
]

Expand Down Expand Up @@ -270,7 +273,7 @@ def _create_request(self, item: dict[str, Any]) -> GenerationRequest:
)

return GenerationRequest(
request_type="text_completions",
request_type=settings.preferred_route,
content=item[self.column_mappings["prompt_column"]],
stats=(
{"prompt_tokens": prompt_tokens} if prompt_tokens is not None else {}
Expand Down