Skip to content

CI/CD Build Fixes for Release #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

CI/CD Build Fixes for Release #126

merged 1 commit into from
Apr 18, 2025

Conversation

markurtz
Copy link
Member

No description provided.

@markurtz markurtz requested a review from Copilot April 18, 2025 20:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI/CD workflows for various build types by replacing the previous method of setting environment variables via appending to $GITHUB_ENV with inline export commands in the build step.

  • Removed the dedicated "Set environment variables" step
  • Combined environment variable setup with the build command execution
  • Updated four workflow files (.github/workflows/release.yml, release-candidate.yml, nightly.yml, development.yml) to use the export pattern

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Uses inline export commands for release builds
.github/workflows/release-candidate.yml Uses inline export commands for release_candidate builds
.github/workflows/nightly.yml Uses inline export commands for nightly builds
.github/workflows/development.yml Uses inline export commands for dev builds, with build_number tied to pull_request.number
Files not reviewed (1)
  • tox.ini: Language not supported

Copy link

Build artifacts (.whl and .tar.gz) are available for download for up to 30 days.
They are located at https://github.com/neuralmagic/guidellm/actions/runs/14541594583/artifacts/2971747055

@markurtz markurtz merged commit 876775f into main Apr 18, 2025
27 checks passed
@markurtz markurtz deleted the cicd-fixes branch April 18, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant