Skip to content

Update CICD flows to enable automated releases and match the feature set laid out in #56 #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025

Conversation

markurtz
Copy link
Member

@markurtz markurtz commented Apr 18, 2025

Fixes #56 and should enable 0.2.0 release plus automated releases going forward

Copy link

github-actions bot commented Apr 18, 2025

Build artifacts (.whl and .tar.gz) are available for download for up to 30 days.
They are located at https://github.com/neuralmagic/guidellm/actions/runs/14541356082/artifacts/2971671543

@markurtz markurtz requested review from Copilot and sjmonson April 18, 2025 20:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various CI/CD workflows to support automated releases and aligns the build process with the feature set outlined in #56. Key changes include:

  • Modifications in build properties handling in utils/inject_build_props.py.
  • Refinements to the scheduler processing logic.
  • Updates to multiple GitHub workflow files for release, nightly, release candidate, main, and development pipelines.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
utils/inject_build_props.py Modified build property construction to return a constant project name.
src/guidellm/scheduler/worker.py Simplified error message formatting in async worker.
src/guidellm/scheduler/scheduler.py Reformatted the computation of request limits for process scheduling.
.github/workflows/release.yml Changed trigger from branch pushes to version tags and updated test commands.
.github/workflows/release-candidate.yml Added new workflow for release candidates with corresponding build steps.
.github/workflows/nightly.yml Adjusted Python version matrices and updated test commands and artifact steps.
.github/workflows/main.yml Introduced a comprehensive main workflow for quality, type, and unit tests.
.github/workflows/development.yml Expanded development workflow with additional build and artifact steps.
Files not reviewed (1)
  • .github/workflows/quality.yml: Language not supported
Comments suppressed due to low confidence (3)

.github/workflows/release.yml:67

  • Removal of coverage reporting flags may reduce visibility into test coverage; consider reintroducing them if coverage metrics are required by your quality standards.
run: tox -e test-unit

utils/inject_build_props.py:38

return "guidellm", version

.github/workflows/nightly.yml:22

  • The extra '-m' flag may be unintended and could affect test marker filtering; please verify if this flag is necessary.
run: tox -e test-unit -- -m --cov=guidellm --cov-report=term-missing --cov-fail-under=75

Co-authored-by: Samuel Monson <smonson@redhat.com>
@markurtz markurtz merged commit 84c504f into main Apr 18, 2025
11 checks passed
@markurtz markurtz deleted the cicd-updates branch April 18, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] GitHub Actions CI/CD Enablement and Expansion
2 participants