Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Redefine ARG between stages #1408

Merged
merged 2 commits into from
Nov 16, 2023
Merged

[BugFix] Redefine ARG between stages #1408

merged 2 commits into from
Nov 16, 2023

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Nov 15, 2023 •
edited
Loading

Recently a bug was caught by @mgoin where our nightly docker images were not actually installing nightlies;

This was because the BRANCH arg was not redefined b/w stages and docker does not persist arg values across stages;
This PR fixes that

@rahul-tuli rahul-tuli mentioned this pull request Nov 15, 2023
Merged
mgoin
mgoin approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting and thanks for adding the deepsparse pip check!

@mgoin mgoin merged commit cf022fe into main Nov 16, 2023
@mgoin mgoin deleted the docker-nightly-workflow-fixes branch November 16, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@Satrat Satrat Awaiting requested review from Satrat

@bfineran bfineran Awaiting requested review from bfineran

@dsikka dsikka Awaiting requested review from dsikka

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul-tuli @mgoin