This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[bug] Add out of the box support for deployment_directories#1131
Merged
rahul-tuli merged 3 commits intomainfrom Jul 20, 2023
Merged
[bug] Add out of the box support for deployment_directories#1131rahul-tuli merged 3 commits intomainfrom
rahul-tuli merged 3 commits intomainfrom
Conversation
dsikka
approved these changes
Jul 20, 2023
bfineran
approved these changes
Jul 20, 2023
Contributor
bfineran
left a comment
There was a problem hiding this comment.
May need to extend behavior in future to allow for names besides model.onnx. LGTM for existing support
Member
Author
That would be very easy; just a one line change would do, Pathlib has a function for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our pipelines did not support using directories(with
model.onnx) out of the box for deployment with server; Noting this used to work with certain tasks as a few pipelines did implement the logic to process deployment directories.Current PR propagates this support to all Pipelines; essentially it updates
model_to_pathfunction (used by all pipelines) to accept model directories as valid inputs; The test was performed using yolov5 model (as OD pipelines did not support model_directories initially)Test:
model:
deepsparse.server: