wmc in the FFI #184
Merged
wmc in the FFI #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattxwang
reviewed
Oct 24, 2023
| bdd: *mut BddPtr<'static>, | ||
| wmc: *mut WmcParams<RealSemiring>, | ||
| ) -> f64 { | ||
| DDNNFPtr::unsmoothed_wmc(&(*bdd), &(*wmc)).0 |
There was a problem hiding this comment.
@stites should this be unsmoothed? If the weights don't add up to 1.0, this will give you an inaccurate WMC (I think this is why I didn't add this in the first pass).
|
@stites can you resolve the merge conflicts (seems to be from nix)? I want to merge this to unblock Cameron. |
|
FYI @minsungc this shouldn't break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaks rsdd-ocaml since I've removed
bdd_new_var. Happy to add it back, but I think the FFI library should be responsible for the sugar that new_var was intended to provide.