First draft on concrete test example #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is this failing???? Hopefully no bug in WMC/fold ... but rsdd is giving the "wrong" answer
|
Note to self: I assumed the BDDs/SDDs were smooth, when they weren't 🤦 |
mattxwang
added a commit
that referenced
this pull request
Jul 14, 2023
Piggybacking from #127! Some food for thought: should we tie `VarOrder` (or `VTree`) to the pointer type itself? Upon further thought, it's interesting to me that the ordering is tied to the builder. For now, the smoothing makes the assumption that all BDDs from the builder have the same order.
|
Closed (tentatively) by #141; may visit later if we smooth SDDs, but that's a whole different conversation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this failing???? Hopefully no bug in WMC/fold ... but rsdd is giving the "wrong" answer