fix initializer for kamada_kawai_layout (networkx #3658) #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boothby
force-pushed
the
master
branch
2 times, most recently
from
491ba56
to
4d94fa5
Compare
|
This looks good. Anything else before we merge? The smoke tests could all use removing |
|
Absolutely; I just went along with the existing pattern, but I'll update the PR today or tomorrow. |
kazimierz-256
pushed a commit
to kazimierz-256/networkx
that referenced
this pull request
Mar 20, 2020
…workx#3782) * fixed high-dimensional initializer for kamada_kawai_layout (networkx networkx#3658) * added tests for kamada_kawai 3d * increased test coverage of kamada_kawai_layout * fixed empty-graph oversight in kamada_kawai_layout * removed unused variable vpos from smoke tests Fixes networkx#3658
kiryph
pushed a commit
to kiryph/networkx
that referenced
this pull request
Jul 21, 2020
…workx#3782) * fixed high-dimensional initializer for kamada_kawai_layout (networkx networkx#3658) * added tests for kamada_kawai 3d * increased test coverage of kamada_kawai_layout * fixed empty-graph oversight in kamada_kawai_layout * removed unused variable vpos from smoke tests Fixes networkx#3658
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
…workx#3782) * fixed high-dimensional initializer for kamada_kawai_layout (networkx networkx#3658) * added tests for kamada_kawai 3d * increased test coverage of kamada_kawai_layout * fixed empty-graph oversight in kamada_kawai_layout * removed unused variable vpos from smoke tests Fixes networkx#3658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at #3658