Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Conversation

Lamaun
Copy link
Contributor

@Lamaun Lamaun commented Oct 31, 2019

The change of networkx graph data structure broke this package.

@@ -127,7 +127,7 @@ def node_nested_dissection(G, weight='weight', options=None):
if len(G) == 0:
return []

vwgt = [G.node[u].get(weight, 1) for u in G]
vwgt = [dict(G.nodes)[u].get(weight, 1) for u in G]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G.node[u] -- > G.nodes[u] should work.

@@ -24,7 +24,7 @@ def setUp(self):
self.node_list = ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
1, 2, 3, 4, 5, 6]
self.G = nx.Graph()
self.G.add_path(self.node_list)
self.G.update(nx.path_graph(self.node_list))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.G.add_path(stuff) -- > nx.add_path(self.G, stuff) is a good way to add a path.

@dschult
Copy link
Member

dschult commented Oct 31, 2019

This repository hasn't been actively updated in a while.
Probably the python versions tested on Travis should match the current networkx versions.
It is possible that other deprecated functionality from NetworkX could cause problems too.
Thanks for doing this!

@Lamaun
Copy link
Contributor Author

Lamaun commented Oct 31, 2019

I haven't worked with travis yet, should we replace travis.yml with something similar to https://github.com/networkx/networkx/blob/master/.travis.yml?

@dschult
Copy link
Member

dschult commented Oct 31, 2019

Can you try a more simple change first? I'm hoping it doesn't require the more heavy lifting.

Change it to python versions 3.6, 3.7, 3.8, pypy3 and let's see what Travis says.
Thanks!

@Lamaun
Copy link
Contributor Author

Lamaun commented Oct 31, 2019

Seems like that works

@dschult
Copy link
Member

dschult commented Oct 31, 2019

Excellent -- anything else before we merge?

@Lamaun
Copy link
Contributor Author

Lamaun commented Oct 31, 2019

Not from my side. Could we get this into pypi?

@dschult
Copy link
Member

dschult commented Oct 31, 2019

I'll look into getting it into pypi.

@dschult dschult merged commit 34398b7 into networkx:master Oct 31, 2019
@dschult dschult added this to the networkx-metis-1.0 milestone Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants