Skip to content

drivers/upsdrvctl.c: forkexec(): double-quote the WIN32 argv[0] in commandline #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimklimov merged 1 commit into from
Feb 10, 2026
Merged

drivers/upsdrvctl.c: forkexec(): double-quote the WIN32 argv[0] in commandline #3307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions drivers/upsdrvctl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,8 +952,11 @@ static void forkexec(char *const argv[], const ups_t *ups)

/* the command line is made of the driver name followed by args */
if (strstr(argv[0], ups->driver)) {
/* We already know whom to call (got a pointer to needle in the haystack) */
snprintf(commandline, sizeof(commandline), "%s", argv[0]);
/* We already know whom to call (got a pointer
* to needle in the haystack); that path may
* have spaces ("Program Files") so quoted.
*/
snprintf(commandline, sizeof(commandline), "\"%s\"", argv[0]);
} else {
/* Hope for the PATH based resolution to work, perhaps the
* driver program is located nearby (depends on configure
Expand All @@ -966,6 +969,7 @@ static void forkexec(char *const argv[], const ups_t *ups)
}

while (argv[i] != NULL) {
/* TOTHINK: No known toxic spaces to quote here... */
snprintfcat(commandline, sizeof(commandline), " %s", argv[i]);
i++;
}
Expand Down
Loading