Refactor `void*` casting to specific types, indentations and other noisy stuff#3297

Merged

jimklimov merged 16 commits intonetworkupstools:masterfrom

jimklimov:issue-3293-refactoring

Feb 4, 2026

Commits on Feb 2, 2026

Fix compiler warnings about copy ellision

timn
authored and
jimklimov
committed
Fix unrelated compiler warnings to be able to complete distcheck

timn
authored and
jimklimov
committed
Add nullptr checks and wrong enum cast

timn
authored and
jimklimov
committed
NEWS.adoc: note the pointer-casting refinement [#3293]
jimklimov
committed
drivers/apc_modbus.c: bump DRIVER_VERSION due to refined setting of mapping table entry types etc. via enum values [#3293]
jimklimov
committed
*.{c,h}: rectify indentations and line-wrapping in general code structure and method arguments
jimklimov
committed
clients/upsmon.c: indent back a block of code changed by the PR [#3293]
jimklimov
committed
clients/upsmon.c: there is little point checking configfile for non-NULLness at the beginning of main() [#3293]
jimklimov
committed
drivers/libshut.c, drivers/netxml-ups.c: standardize on "try_num" as the iteration variable name
jimklimov
committed
drivers/nutdrv_qx.c: revert bogus change to qx_process() error handling of xmalloc() [#3293]
jimklimov
committed
server/upsd.c: add a comment to FTS_T *fds [#3293]
jimklimov
committed
drivers/mge-hid.c: add a note about using enum value in sentinel for mge_model_names[] [#3293]
jimklimov
committed
tools/nut-scanner/*.c: use `(lt_dlhandle)1` casting instead of `(void *)1` also in comparisons
jimklimov
committed
tools/nut-scanner/scan_ipmi.c: uncomment code block that detects "No IPMI on this host" to report the message
jimklimov
committed
tools/nut-scanner/scan_*.c: fix more inconsistent indentations
jimklimov
committed
*.{c,h}: rectify more indentations and line-wrapping in block comments
jimklimov
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Refactor `void*` casting to specific types, indentations and other noisy stuff#3297

Refactor `void*` casting to specific types, indentations and other noisy stuff#3297
jimklimov merged 16 commits intonetworkupstools:masterfrom
jimklimov:issue-3293-refactoring

Commits on Feb 2, 2026

Fix compiler warnings about copy ellision

Fix unrelated compiler warnings to be able to complete distcheck

Add nullptr checks and wrong enum cast

NEWS.adoc: note the pointer-casting refinement [#3293]

drivers/apc_modbus.c: bump DRIVER_VERSION due to refined setting of mapping table entry types etc. via enum values [#3293]

*.{c,h}: rectify indentations and line-wrapping in general code structure and method arguments

clients/upsmon.c: indent back a block of code changed by the PR [#3293]

clients/upsmon.c: there is little point checking configfile for non-NULLness at the beginning of main() [#3293]

drivers/libshut.c, drivers/netxml-ups.c: standardize on "try_num" as the iteration variable name

drivers/nutdrv_qx.c: revert bogus change to qx_process() error handling of xmalloc() [#3293]

server/upsd.c: add a comment to FTS_T *fds [#3293]

drivers/mge-hid.c: add a note about using enum value in sentinel for mge_model_names[] [#3293]

tools/nut-scanner/.c: use `(lt_dlhandle)1` casting instead of `(void )1` also in comparisons

tools/nut-scanner/scan_ipmi.c: uncomment code block that detects "No IPMI on this host" to report the message

tools/nut-scanner/scan_*.c: fix more inconsistent indentations

*.{c,h}: rectify more indentations and line-wrapping in block comments