upsdrvctl did not play along with ENABLE_SHARED_PRIVATE_LIBS well#3292
Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom Feb 2, 2026
Merged
upsdrvctl did not play along with ENABLE_SHARED_PRIVATE_LIBS well#3292jimklimov merged 2 commits intonetworkupstools:masterfrom
upsdrvctl did not play along with ENABLE_SHARED_PRIVATE_LIBS well#3292jimklimov merged 2 commits intonetworkupstools:masterfrom
Conversation
…ED_PRIVATE_LIBS [networkupstools#2800] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…older vs. ENABLE_SHARED_PRIVATE_LIBS [networkupstools#2800] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
CI
|
❌ Build nut 2.8.4.4135-master failed (commit 31e183ec0d by @jimklimov) |
Member
Author
|
Adding upsdrvctl to NIT was not as trivial as hoped: something not found on Appveyor at least... Possibly DLLs not in the right path?.. |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 1, 2026
…sted spelling of ABS_TOP_SRCDIR and ABS_TOP_BUILDDIR so it ends up in "driverpath" correctly for WIN32 builds [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 1, 2026
… not only quoted but also with escaped backslashes [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 2, 2026
…sted spelling of ABS_TOP_SRCDIR and ABS_TOP_BUILDDIR so it ends up in "driverpath" correctly for WIN32 builds [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 2, 2026
… not only quoted but also with escaped backslashes [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 4, 2026
…sted spelling of ABS_TOP_SRCDIR and ABS_TOP_BUILDDIR so it ends up in "driverpath" correctly for WIN32 builds [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 4, 2026
… not only quoted but also with escaped backslashes [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #2800 and #3291.
Perhaps the NIT suite should use the tool instead of directly starting the driver programs; then this would have been caught. Maybe some other day though... => offloaded to #3294 (there are some hiccups that need a few more coding iterations to unravel)