Skip to content

Fix common USB matching options for bcmxcp_usb #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix common USB matching options for bcmxcp_usb #2270

wants to merge 4 commits into from
+42 −4

Conversation

jimklimov
Copy link
Member

@jimklimov jimklimov commented Jan 19, 2024 •
edited
Loading

Parked per #1764 and #1763, something like this should be needed to solve #597 (but progress on development should better be tested against real devices):

Note: "bcmxcp_usb" driver suffers a similar problem but was not easy to fix in a similar fashion (conflicts with symbols in the built LIBUSB_IMPL of the day, and impacts nut-scanner build per different dependency chain), so attempt to fix it along with others was shelved.

Posting as a PR to avoid dropping the source branch (and to let CI give it a shot) :)

@jimklimov jimklimov added MGE MGE branded devices and (USB) chipsets, now part of Eaton; mostly bcmxcp drivers Qx protocol driver Driver based on Megatec Q<number> such as new nutdrv_qx, or obsoleted blazer and some others USB-duplicate-devices Track bugs and issues about monitoring several devices that seem identical to NUT or libusb and removed Qx protocol driver Driver based on Megatec Q<number> such as new nutdrv_qx, or obsoleted blazer and some others labels Jan 19, 2024
@jimklimov jimklimov added need testing Code looks reasonable, but the feature would better be tested against hardware or OSes needs-work PR discussion concluded that some work is needed from the contributor labels Jan 19, 2024
@jimklimov jimklimov marked this pull request as draft January 19, 2024 13:21
@AppVeyorBot
Copy link

❌ Build nut 2.8.1.1313-master failed (commit 4132f4deee by @jimklimov)

@jimklimov
Merge branch 'master' into issue-1754-bcmxcp
420be53 
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@AppVeyorBot
Copy link

❌ Build nut 2.8.3.3011-master failed (commit 8c9f2bc899 by @jimklimov)

@jimklimov
Copy link
Member Author

Resyncing with main NUT code base after v2.8.3 release.

@jimklimov jimklimov marked this pull request as ready for review April 25, 2025 08:27
@jimklimov jimklimov added this to the 2.8.4 milestone Apr 25, 2025
@jimklimov
Copy link
Member Author

Parked code has got a few issues to address:

/usr/bin/ld: ./.libs/libnutscan.so: undefined reference to `bcmxcp_makevartable'

/usr/bin/ld: libusb0.o:(.data+0x0): multiple definition of `comm_upsdrv_info'; bcmxcp_usb.o:(.data+0x0): first defined here

@jimklimov jimklimov marked this pull request as draft April 25, 2025 08:49
@jimklimov jimklimov modified the milestones: 2.8.4, 2.8.5 Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MGE MGE branded devices and (USB) chipsets, now part of Eaton; mostly bcmxcp drivers need testing Code looks reasonable, but the feature would better be tested against hardware or OSes needs-work PR discussion concluded that some work is needed from the contributor USB-duplicate-devices Track bugs and issues about monitoring several devices that seem identical to NUT or libusb
Projects
None yet
Milestone
2.8.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jimklimov @AppVeyorBot