Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbhid-ups: Deprecate onlinedischarge option as ambiguous #2213

Closed
jimklimov opened this issue Dec 5, 2023 · 0 comments · Fixed by #2216
Closed

usbhid-ups: Deprecate onlinedischarge option as ambiguous #2213

jimklimov opened this issue Dec 5, 2023 · 0 comments · Fixed by #2216
Labels
documentation enhancement USB
Milestone
2.8.2

Comments

@jimklimov
Copy link
Member

Now that we have onlinedischarge_calibration and more are looming, a better name here would be onlinedischarge_onbattery or similar.

Old one would be accepted in same meaning, of course, but no longer recommended.
@jimklimov jimklimov added this to the 2.8.2 milestone Dec 5, 2023
jimklimov added a commit to jimklimov/nut that referenced this issue Dec 5, 2023
@jimklimov
drivers/usbhid-ups.c, docs/man/usbhid-ups.txt, NEWS.adoc: deprecate "…
ea2ab71 
…onlinedischarge" in favor of "onlinedischarge_onbattery" option name [networkupstools#2213]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov mentioned this issue Dec 5, 2023
Merged
mateusz-jastrzebski pushed a commit to mateusz-jastrzebski/nut-with-galaxy5500 that referenced this issue Dec 20, 2023
Added support for APC Galaxy 5500 UPS
9ac6ca3 
README.adoc: use DigitalOcean referral campaign identifier in badge URL [networkupstools#2192]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>

drivers/usbhid-ups.c, docs/man/usbhid-ups.txt, NEWS.adoc: deprecate "onlinedischarge" in favor of "onlinedischarge_onbattery" option name [networkupstools#2213]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>

drivers/usbhid-ups.c, docs/man/usbhid-ups.txt, NEWS.adoc: introduce "onlinedischarge_log_throttle_sec" setting and/or throttling by changes of battery.charge [networkupstools#2214]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>

drivers/usbhid-ups.c, docs/man/usbhid-ups.txt, NEWS.adoc: introduce "onlinedischarge_log_throttle_hovercharge" setting [networkupstools#2215]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: mjastrzebski <mjastrzebski@ibb.waw.pl>
mateusz-jastrzebski pushed a commit to mateusz-jastrzebski/nut-with-galaxy5500 that referenced this issue Dec 20, 2023
@mateusz-jastrzebski
Added support for APC Galaxy 5500 UPS
a12aef1 
README.adoc: use DigitalOcean referral campaign identifier in badge URL [networkupstools#2192]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>

drivers/usbhid-ups.c, docs/man/usbhid-ups.txt, NEWS.adoc: deprecate "onlinedischarge" in favor of "onlinedischarge_onbattery" option name [networkupstools#2213]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>

drivers/usbhid-ups.c, docs/man/usbhid-ups.txt, NEWS.adoc: introduce "onlinedischarge_log_throttle_sec" setting and/or throttling by changes of battery.charge [networkupstools#2214]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>

drivers/usbhid-ups.c, docs/man/usbhid-ups.txt, NEWS.adoc: introduce "onlinedischarge_log_throttle_hovercharge" setting [networkupstools#2215]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: mjastrzebski <mjastrzebski@ibb.waw.pl>
Signed-off-by: mjastrzebski <jasmati09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement USB
Projects
None yet
Milestone
2.8.2
Development

Successfully merging a pull request may close this issue.

usbhid-ups: allow to throttle or suppress logged messages about OL+DISCHRG situation jimklimov/nut
1 participant
@jimklimov