Skip to content

NetBox 2.9 support #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

mzbroch
Copy link
Contributor

@mzbroch mzbroch commented Aug 31, 2020

This PR introduces the support of NetBox 2.9 into the ntc-netbox-plugin-onboarding project.

The goal is to provide support for two NetBox releases by the plugin: 2.8 and 2.9. Due to significant Permission related changes in NetBox 2.9, onboardingtask views needed to be modified.

The following changes are a part of this single commit :

  • filters.py - duplicated site_id
  • search fixed in filters
  • OnboardingTaskFeedCSVForm now inherits from CSVModelForm (fixes NetBox 2.9 - Bulk onboarding #88 )
  • conditional (if 2.9) model attribute in OnboardingTask model
  • fixed the reverse names to follow NetBox convention
  • added release statements in release.py
  • dedicated view for a single onboarding task
  • Onboarding Task tables now show Link Column for Onboarding Task id
  • replaced existing view's unit tests with NetBox unit tests, still separated for NetBox 2.8 and 2.9
  • conditionals in unit tests (2.8 or 2.9)
  • conditionals in view classes (2.8 or 2.9)

@mzbroch mzbroch changed the base branch from mzb-netbox-keeper-disaggregation to develop-2.0 August 31, 2020 11:46
@mzbroch mzbroch changed the base branch from develop-2.0 to mzb-netbox-keeper-disaggregation August 31, 2020 11:46
@mzbroch mzbroch changed the title Updated ip address assignment method [WIP] Updated ip address assignment method Sep 1, 2020
@mzbroch mzbroch changed the title [WIP] Updated ip address assignment method NetBox 2.9 support Sep 2, 2020
@mzbroch mzbroch force-pushed the mzb-netbox-2.9 branch 2 times, most recently from 7876c16 to beafb78 Compare September 2, 2020 16:14
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dgarros dgarros self-requested a review September 14, 2020 12:11
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Marek

@dgarros dgarros merged commit 12694d6 into mzb-netbox-keeper-disaggregation Sep 14, 2020
@hyudra
Copy link

hyudra commented Sep 15, 2020

Hello,

Is this version merged for pip library?
I still get error message 'Direct assignment to the reverse side of a related set is prohibited. Use interface.set() instead.'

@dgarros
Copy link
Contributor

dgarros commented Sep 15, 2020

@hyudra no it's not available on pypi yet, out goal is to have a beta version for 2.9 out sometime this week but it won't be production ready

@hyudra
Copy link

hyudra commented Sep 15, 2020

Noted with thanks. I'll looking forward to it :).

@dgarros dgarros deleted the mzb-netbox-2.9 branch September 15, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants