Update plugin for 2.10 #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
approved these changes
Dec 23, 2020
|
|
In 41e3b1a I added two OnboardingTask template files that are NetBox version dependent - this is for NetBox 2.8 and 2.9 support - other potential solution could be through registering django template tags and re-using a common variable name inside a template, but although technically more powerful, complexity was increased. |
mzbroch
approved these changes
Dec 29, 2020
|
Looks good to me, Glenn is out this week and since there is a growing number of requests for 2.10 support I propose we merge it and publish a new release ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.