Refactor of DNS resolving #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzbroch
force-pushed
the
mzb-dns
branch
2 times, most recently
from
fedf22f to
2c87be1
Compare
|
Looks reasonable. One thing that's not clear to me, does the entered FQDN still get stored anywhere in the final onboarded device? |
Not at the moment - We do resolution once the worker picks up the task and save resolved FQDN into the |
|
@jvanderaa Let us know if this change solves your issue |
|
Checking still. In the interim we should also add the unit test that I have added on the branch uploaded. @mzbroch |
jvanderaa
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardises the process of DNS resolution in the Onboarding Plugin.
In the onboarding task, is it possible to specify a FQDN to be onboarded. Plugin is expected to resolve that name into IP address and use it for connections.
With this PR, a FQDN is resolved once per OT lifetime and rewritten into an
ip_addressattribute of the model. This assures consistency in all of the code and eliminates the need for accounting for IP/FQDN.Fixes #106