Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use diffsync store methods #267

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Use diffsync store methods #267

merged 3 commits into from
Jun 9, 2022

Conversation

chadell
Copy link
Contributor

@chadell chadell commented Jun 9, 2022

Addresses #266

Simply replaces the access to internal arguments of diffsync adapter by its public methods

jvanderaa
jvanderaa approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell chadell merged commit e87781e into develop Jun 9, 2022
@chadell chadell mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanderaa jvanderaa jvanderaa approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadell @jvanderaa