Skip to content

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Mar 2, 2025

No description provided.

@stevehu stevehu merged commit c22528d into master Mar 2, 2025
@stevehu stevehu deleted the issue67 branch March 2, 2025 22:06
@AndreasALoew
Copy link
Contributor

@stevehu , I really don't understand why you did not like to introduce an external - well maintained - library to vaildate e-mail-addresses, but instead seem to prefer to rely on some hand-crafted and hard-to-maintain regexp-based code compiled from the net, but as we have at least reached the goal of removing "javax.mail" implementations creating legal issues with Oracle I am ok with this as the final result.

Can you please release an official version of openapi-parser which contains this commit soon, such that we can release our product referencing a non-SNAPSHOT version of openapi-parser as our dependency?

Many thanks! 👍

@stevehu
Copy link
Contributor Author

stevehu commented Mar 3, 2025

The openapi-parser uses in the light-4j framework and there are other dependencies that cause conflicts. That is why I have to move some of the classes from the json-schema-validator. We are in a heavy development now and this lib will be released all together. I am planning to release at the end of March or early April. I can release a snapshot version 2.2.1-SNAPSHOT for your testing. Let me know if this works for you. Thanks.

@AndreasALoew
Copy link
Contributor

AndreasALoew commented Mar 3, 2025

I can release a snapshot version 2.2.1-SNAPSHOT for your testing. Let me know if this works for you.

Thanks for the offering, but that shouldn't be necessary. We are expected (and also statically checked) to NOT include SNAPSHOT versions into release builds.

But I can definitely build the current master/HEAD "snapshot" version from your official Github repo on my own and deploy it only locally to our in-house Artifactory as a "release" version named/numbered "2.2.1-pre-20250303" (or similar) and then later migrate to an "official" version from Maven Central once it is ready.

Never mind & best regards,
Andreas

@RohanNagar
Copy link

Hi @stevehu I am the maintainer of the jmail library that has been referenced in this issue and I happened to stumble across this.

I was curious as to why jmail did not fit your needs here. Could you explain a little bit so I can understand where my library needs more improvement? Thank you!

@stevehu
Copy link
Contributor Author

stevehu commented Jun 1, 2025

It has nothing to do with the library. You have a great library, the reason I have to switch to regex is due to the conflict with client applications. The mail api is messed up by the client applications and we cannot force them to change and removing the dependency is our only option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants