Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept default group key in Http2Client #423

Closed
dz-1 opened this issue Mar 6, 2019 · 2 comments
Closed

accept default group key in Http2Client #423

dz-1 opened this issue Mar 6, 2019 · 2 comments
Assignees
@dz-1

Comments

@dz-1
Copy link
Contributor

dz-1 commented Mar 6, 2019 •
edited
Loading

To achieve hostname verification in CaaS environments, users need to config trustedNames in client.yml and create customized XnioSsl instances. The default Http2Client.SSL does not accept any trustedNames settings.

It turns out that this is not convenient and impacts many client side code. To address this issue, we propose to introduce another config item defaultGroupKey into client.yml.

If defaultGroupKey is configured, the Http2Client.SSL will use the specified key to find trusted names. If this key is not configured, the default HTTPS verification is used.

An example config is shown below:

tls:
  verifyHostname: true
  defaultGroupKey: trustedNames.group1
  trustedNames:
    group1: service_id1, service_id2
@dz-1 dz-1 self-assigned this Mar 6, 2019
dz-1 added a commit that referenced this issue Mar 6, 2019
@dz-1
accept defaultGroupKey in Http2Client.SSL - #423
d55293f
stevehu pushed a commit that referenced this issue Mar 15, 2019
@dz-1 @stevehu
accept defaultGroupKey in Http2Client.SSL - #423 (#424)
d9d5ea4
@stevehu stevehu closed this as completed Mar 20, 2019
@stevehu
Copy link
Contributor

stevehu commented Mar 20, 2019

accept default group key in Http2Client

@stevehu
Copy link
Contributor

stevehu commented Mar 24, 2019

accept default group key in Http2Client

younggwon1 pushed a commit to younggwon1/light-4j that referenced this issue Feb 10, 2024
@dz-1 @stevehu
accept defaultGroupKey in Http2Client.SSL - networknt#423 (networknt#424
a2200e4 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dz-1 dz-1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevehu @dz-1