Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message #975

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix message #975

merged 1 commit into from
Feb 22, 2024

Conversation

justin-tay
Copy link
Contributor

This fixes the use of message in a validator. Currently this always gets overridden.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bc93b44) 78.75% compared to head (576c656) 78.75%.

Files Patch % Lines
...tworknt/schema/MessageSourceValidationMessage.java 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #975   +/-   ##
=========================================
  Coverage     78.75%   78.75%           
- Complexity     1850     1851    +1     
=========================================
  Files           164      164           
  Lines          5987     5988    +1     
  Branches       1146     1147    +1     
=========================================
+ Hits           4715     4716    +1     
+ Misses          837      836    -1     
- Partials        435      436    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit fed46cf into networknt:master Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants