-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor format validation #958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
============================================
- Coverage 79.01% 78.79% -0.23%
- Complexity 1726 1767 +41
============================================
Files 158 160 +2
Lines 5753 5797 +44
Branches 1087 1080 -7
============================================
+ Hits 4546 4568 +22
- Misses 809 825 +16
- Partials 398 404 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #957, closes #848
This shouldn't contain any breaking changes, instead some methods are deprecated with some workarounds to cater to the old behavior.
This refactors the format validation to do the following
Custom Format
https://json-schema.org/draft/2020-12/json-schema-validation#name-foreword
Unknown Format
https://json-schema.org/draft/2020-12/json-schema-validation#name-custom-format-attributes
Note that having the vocab is different from enabling assertions as an option.