Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale.ENGLISH should set #951

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Locale.ENGLISH should set #951

merged 1 commit into from
Feb 5, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #949

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85d642b) 78.96% compared to head (7153271) 78.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #951   +/-   ##
=========================================
  Coverage     78.96%   78.96%           
  Complexity     1714     1714           
=========================================
  Files           157      157           
  Lines          5710     5710           
  Branches       1076     1076           
=========================================
  Hits           4509     4509           
  Misses          802      802           
  Partials        399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 61bf64a into networknt:master Feb 5, 2024
4 checks passed
@justin-tay justin-tay deleted the gh949 branch February 6, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchemaValidatorConfig.setLocale(ENGLISH) does not work when running from non-english environments
3 participants