Introduce forceHttps
flag in JsonSchemaFactory.Builder
#400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e32a541, schema normalization was introduced to fix #273 however it assumes the given schema is available over HTTPS.
json-schema-validator/src/main/java/com/networknt/schema/JsonSchemaFactory.java
Line 406 in e32a541
As reported in #314, some schemas are not available over HTTPS. For example, https://iglucentral.com (it just hangs with https), see snowplow/iglu-central#1067.
Therefore #314 blocks snowplow/iglu-scala-client#136 and our internal
json-schema-validator
dependency upgrade from1.0.39
to1.0.40+
.The first commit in this PR provides a failing test for #314 and the second one introduces a boolean flag to control the URI scheme.
Fixes #314.