Skip to content

fix #21 Use of "id" field does not work for field reference #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2017

Conversation

eskabetxe
Copy link
Contributor

No description provided.

@stevehu
Copy link
Contributor

stevehu commented Apr 1, 2017

Thanks @eskabetxe for your contribution. There are some existing test cases failed with the change and I am planning to look into it once I get time. It would be great if you could take a look what the root cause and fix it. Happy coding!

@eskabetxe
Copy link
Contributor Author

@stevehu resolved, sorry i take a wile to understand the problem..
there are some issues if the "id" as the same value as "schema" causing some infinite loop

@stevehu stevehu merged commit 092da86 into networknt:master Apr 3, 2017
@stevehu
Copy link
Contributor

stevehu commented Apr 3, 2017

@eskabetxe Thanks a lot for your help.

@stevehu
Copy link
Contributor

stevehu commented Apr 4, 2017

@eskabetxe I am wondering if you could help to add a test case for the subschema to ensure other people's changes won't break your code.

@eskabetxe
Copy link
Contributor Author

I had already thought about it.
The problem is that it will be necessary a url with a valid scheme
Could we use a url to a file in repository (github)?

@stevehu
Copy link
Contributor

stevehu commented Apr 4, 2017

Not necessary. I have undertow included in the test scope already and going to start a test server for this purpose. I have some other remote schemas that need to be tested as well. Give me some time and I will put it in. Hopefully this weekend. Thanks for reminding me:)

@stevehu
Copy link
Contributor

stevehu commented Apr 10, 2017

@eskabetxe As per our discussion, I have added undertow server in the test for remote references. Let me know if you have any questions. Thanks.

@eskabetxe
Copy link
Contributor Author

@stevehu sorry for the delay..
I didnt have time available before, i will check this asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants