Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate config for unevaluatedItems and unevaluatedProperties #1059

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

justin-tay
Copy link
Contributor

Deprecate config for unevaluatedItems and unevaluatedProperties as this is no longer needed and doesn't do anything since the validators were rewritten to use annotations as it doesn't cost additional performance by collecting annotations if not needed and will always collect annotations for the relevant validators if needed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (48ca3c2) to head (8d65876).
Report is 25 commits behind head on master.

Files Patch % Lines
...a/com/networknt/schema/SchemaValidatorsConfig.java 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1059      +/-   ##
============================================
- Coverage     78.90%   78.76%   -0.15%     
- Complexity     1965     2018      +53     
============================================
  Files           172      190      +18     
  Lines          6352     6521     +169     
  Branches       1255     1245      -10     
============================================
+ Hits           5012     5136     +124     
- Misses          867      913      +46     
+ Partials        473      472       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 0ceb03e into networknt:master Jun 13, 2024
4 checks passed
@justin-tay justin-tay deleted the deprecatedisableflags branch June 13, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants