Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the additionalProperties in oneOf failed test cases #516

Closed
stevehu opened this issue Feb 22, 2022 · 3 comments
Closed

fix the additionalProperties in oneOf failed test cases #516

stevehu opened this issue Feb 22, 2022 · 3 comments

Comments

@stevehu
Copy link
Contributor

stevehu commented Feb 22, 2022

These test cases were submitted by @huubfleuren and I just market them as disabled for now. Our developers can pick them up and get them fixed.

@huubfleuren Have you tested under version 1.0.44? Are they fail as well in 1.0.44? Thanks.

@huubfleuren
Copy link
Contributor

huubfleuren commented Feb 22, 2022

Good one. Thanks. I did not test it on 1.0.44, but nowIi have and results differ. It is not flawless either, but where there is ambivalence this is acceptable of course. On the other hand: I think the messages are all correct:

AdditionalPropertiesOneOfFailsTest
test master 1.0.44
heightIsNotMissingNotOnceAndNotTwice() v v
chemicalCharacteristicNameIsAdditional() - -
chemicalCharacteristicCategoryNameIsDefined() v v
heightWrongType() - -
depthIsAdditional() - -
weightIsMissingOnlyOnce() - v
toxicIsAdditional() - v

the errormessages seem to be better (master: failFast=false):

master:

$.activities[0].weight: is missing but it is required
$.activities[0].chemicalCharacteristic: is missing but it is required
$.activities[1].weight: is missing but it is required
$.activities[1].height: is missing but it is required
$.activities[2].weight: is missing but it is required
$.activities[2].height: is missing but it is required

1.0.44

$.activities[0].weight: is missing but it is required
$.activities[0].age: is not defined in the schema and the schema does not allow additional properties
$.activities[1].toxic: is not defined in the schema and the schema does not allow additional properties
$.activities[2].toxic: is not defined in the schema and the schema does not allow additional properties
$.activities[2].chemicalCharacteristic: should be valid to one and only one of the schemas

@stevehu
Copy link
Contributor Author

stevehu commented Feb 22, 2022

@huubfleuren Thanks a lot for your detailed comparison. I think we need a code analysis between the two versions to see what has been changed for the part.

stevehu pushed a commit that referenced this issue Apr 20, 2023
Corrects #678 #516 #197

Co-authored-by: Faron Dutton <faron.dutton@insightglobal.com>
@fdutton
Copy link
Contributor

fdutton commented Apr 20, 2023

Completed in #720

@fdutton fdutton closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants