Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walk method for AnyOfValidator not implemented #451

Closed
bartoszm opened this issue Sep 22, 2021 · 2 comments
Closed

walk method for AnyOfValidator not implemented #451

bartoszm opened this issue Sep 22, 2021 · 2 comments

Comments

@bartoszm
Copy link
Contributor

com.networknt.schema.AnyOfValidator is not implementing walk method. It could look like com.networknt.schema.AllOfValidator#walk I suppose

bartoszm added a commit to bartoszm/json-schema-validator that referenced this issue Sep 22, 2021
stevehu pushed a commit that referenced this issue Sep 22, 2021
@stevehu stevehu closed this as completed Sep 24, 2021
@stevehu stevehu reopened this Oct 8, 2021
@stevehu
Copy link
Contributor

stevehu commented Oct 8, 2021

@bartoszm I have merged some new changes for the walking and it looks like the test case for #451 is broken. Could you please take a look? Thanks.

[ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s <<< FAILURE! - in com.networknt.schema.Issue451Test
[ERROR] shouldWalkAnyOfPropertiesWithWithPayloadAndValidation  Time elapsed: 0.012 s  <<< ERROR!
java.lang.NullPointerException
	at com.networknt.schema.Issue451Test.walk(Issue451Test.java:72)
	at com.networknt.schema.Issue451Test.shouldWalkAnyOfPropertiesWithWithPayloadAndValidation(Issue451Test.java:53)


@stevehu stevehu closed this as completed Oct 10, 2021
@prashanthjos
Copy link
Member

@bartoszm we left it open because it depends on usecase to uasecase. Please feel free to write your version of walk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants