Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support propertyNames #396

Closed
JonasProgrammer opened this issue Apr 11, 2021 · 0 comments
Closed

Properly support propertyNames #396

JonasProgrammer opened this issue Apr 11, 2021 · 0 comments

Comments

@JonasProgrammer
Copy link
Contributor

The current implementation of propertyNames is completely separate from the remaining validation code, implementing special cases for stuff like minLength.

According to the spec, however, propertyNames should be treated like a normal json schema being applied to a text node of the property value.

This has lead to issues, such as #342 and #326.

I propose to just do what the spec says and apply the node content under propertyNames to each field name as if it were a TextNode.

JonasProgrammer added a commit to JonasProgrammer/json-schema-validator that referenced this issue Apr 11, 2021
- implement property names in terms of full schema validation
- add test case for complex property name
- added test case for networknt#342
- fix networknt#375 tests to expect standard messages
- closes networknt#396
- closes networknt#342
JonasProgrammer added a commit to JonasProgrammer/json-schema-validator that referenced this issue Apr 11, 2021
- implement property names in terms of full schema validation
- add test case for complex property name
- added test case for networknt#342
- fix networknt#375 tests to expect standard messages
- closes networknt#396
- closes networknt#342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant