dependentSchemas and dependentRequired keywords not implemented

[gjvoosten]

From JSON Schema 2019-09, the new keywords dependentSchemas and dependentRequired (replacing dependencies) are not implemented; see https://json-schema.org/draft/2019-09/release-notes.html#semi-incompatible-changes

[stevehu]

@gjvoosten Thanks a lot for raising it up. Several keywords are not implemented as our team is not using them at the moment. They are in the pipeline though when we have time. If would be great if you and others can take the time to get them implemented.

[kmalski]

Hi, I have created pull request resolving this issue #479.

[stevehu]

@gjvoosten, the implementation provided by @kmalski has merged to the master branch already. Once several other pending issues are resolved, we will have a new release. Meanwhile, you can test the new keyword with the master branch code. Thanks @kmalski for your help.

[gjvoosten]

Hi @stevehu, apologies for the delay in getting back to you. Release 1.0.64 works regarding the way we use dependentSchemas. [But note that we'd also like to use unevaluatedProperties which is part of issue #276 .]

[stevehu]

@gjvoosten Yes. You are right. That is another keyword we need to implement. Let's see if someone can help. Thanks for the reminder.

[rustermi]

@stevehu is there a list of keywords not yet implemented?

Besides, should dependentRequired work now? Because for me (1.0.66), this test fails:

package com.networknt.schema;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.jupiter.api.Test;
import java.util.Set;
import static org.junit.jupiter.api.Assertions.assertEquals;

public class DependentRequiredTest {
    private ObjectMapper mapper = new ObjectMapper();

    @Test
    public void attributeADependentRequiresB() throws Exception {
        JsonSchemaFactory factory = JsonSchemaFactory.getInstance(SpecVersion.VersionFlag.V7);
        JsonSchema schema = factory.getSchema("{" +
                "  \"$id\": \"https://example.com/testingErrorCodes.schema.json\"," +
                "  \"$schema\": \"http://json-schema.org/draft-07/schema#\"," +
                "  \"type\": \"object\"," +
                "  \"properties\": {" +
                "    \"a\": {" +
                "      \"type\": \"number\"" +
                "    }," +
                "    \"b\": {" +
                "      \"type\": \"number\"" +
                "    }" +
                "  }," +
                "  \"dependentRequired\": {" +
                "    \"a\": [\"b\"]" +
                "  }" +
                "}");
        JsonNode json = mapper.readTree("{\"a\": 5}");
        Set<ValidationMessage> validationMessages = schema.validate(json);
        assertEquals(1, validationMessages.size());
    }
}

It tries to match the object { "a": 5 } (which is missing "b") against a minimum schema:

{
  "$id": "https://example.com/testingErrorCodes.schema.json",
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "a": {
      "type": "number"
    },
    "b": {
      "type": "number"
    }
  },
  "dependentRequired": {
    "a": ["b"]
  }
}

[stevehu]

@rustermi The keyword is implemented and passed the official test suite. I am not very familiar with the keyword as I haven't used it yet. I am wondering if you could create a test case and debug it into the validator to see why it fails. Thanks.

[rustermi]

We currently don't use the keyword either. When we do, I will follow your proposal.

[stevehu]

@rustermi Thanks for your response. I will close this issue for now and will reopen it if needed.