Skip to content

Commit

Permalink
Remove iconv/libiconv checks from *NIX builds: GLIB-2 provides iconv …
Browse files Browse the repository at this point in the history
…replacements.

svn path=/trunk/; revision=25765
  • Loading branch information
Jeff Morriss committed Jul 18, 2008
1 parent 2e78900 commit 86e1088
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 122 deletions.
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ include(CheckFunctionExists)
check_function_exists("chown" HAVE_CHOWN)
check_function_exists("gethostbyname2" HAVE_GETHOSTBYNAME2)
check_function_exists("getprotobynumber" HAVE_GETPROTOBYNUMBER)
check_function_exists("iconv" HAVE_ICONV)
check_function_exists("inet_ntop" HAVE_INET_NTOP_PROTO)
check_function_exists("issetugid" HAVE_ISSETUGID)
check_function_exists("mmap" HAVE_MMAP)
Expand Down
5 changes: 0 additions & 5 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,6 @@ wireshark_LDADD = \
$(plugin_ldadd) \
@PCRE_LIBS@ \
@PCAP_LIBS@ @GTK_LIBS@ @ADNS_LIBS@ @KRB5_LIBS@ @FRAMEWORKS@ \
@LIBICONV@ \
@LIBGCRYPT_LIBS@ \
@LIBGNUTLS_LIBS@ \
@LIBSMI_LDFLAGS@ \
Expand Down Expand Up @@ -346,7 +345,6 @@ tshark_LDADD = \
@GLIB_LIBS@ -lm \
@PCAP_LIBS@ @SOCKET_LIBS@ @NSL_LIBS@ @ADNS_LIBS@ @KRB5_LIBS@ \
@FRAMEWORKS@ \
@LIBICONV@ \
@LIBGCRYPT_LIBS@ \
@LIBGNUTLS_LIBS@ \
@LIBSMI_LDFLAGS@
Expand Down Expand Up @@ -375,7 +373,6 @@ rawshark_LDADD = \
@GLIB_LIBS@ -lm \
@PCAP_LIBS@ @SOCKET_LIBS@ @NSL_LIBS@ @ADNS_LIBS@ @KRB5_LIBS@ \
@FRAMEWORKS@ \
@LIBICONV@ \
@LIBGCRYPT_LIBS@ \
@LIBGNUTLS_LIBS@ \
@LIBSMI_LDFLAGS@
Expand Down Expand Up @@ -431,7 +428,6 @@ dftest_LDADD = \
@PCRE_LIBS@ \
@GLIB_LIBS@ -lm \
@PCAP_LIBS@ @SOCKET_LIBS@ @NSL_LIBS@ @ADNS_LIBS@ @KRB5_LIBS@ \
@LIBICONV@ \
@LIBGCRYPT_LIBS@ \
@LIBGNUTLS_LIBS@ \
@LIBSMI_LDFLAGS@
Expand Down Expand Up @@ -564,7 +560,6 @@ EXTRA_DIST = \
aclocal-fallback/glib.m4 \
aclocal-fallback/gtk-2.0.m4 \
aclocal-fallback/gtk.m4 \
aclocal-fallback/iconv.m4 \
aclocal-flags \
adns_dll.dep \
adns_dll.rc \
Expand Down
1 change: 0 additions & 1 deletion README.bsd
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ Install the latest versions of the following programs before compiling:
glitz
gtk2 / gtk+2
jpeg
libiconv
pango
pkgconfig
png
Expand Down
72 changes: 0 additions & 72 deletions aclocal-fallback/iconv.m4

This file was deleted.

33 changes: 0 additions & 33 deletions cmake/modules/FindGLIB2.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -168,34 +168,6 @@ else (GLIB2_LIBRARIES AND GLIB2_INCLUDE_DIRS)
endif (LIBINTL_LIBRARY AND LIBINTL_INCLUDE_DIR)
##

## libiconv
find_path(LIBICONV_INCLUDE_DIR
NAMES
iconv.h
PATHS
/opt/gnome/include/glib-2.0
/usr/include/glib-2.0
/usr/local/include/glib-2.0
/opt/local/include/glib-2.0
/sw/include/glib-2.0
)

find_library(LIBICONV_LIBRARY
NAMES
iconv
PATHS
/opt/gnome/lib
/usr/lib
/usr/local/lib
/opt/local/lib
/sw/lib
)

if (LIBICONV_LIBRARY AND LIBICONV_INCLUDE_DIR)
set(LIBICONV_FOUND TRUE)
endif (LIBICONV_LIBRARY AND LIBICONV_INCLUDE_DIR)
##

set(GLIB2_INCLUDE_DIRS
${GLIB_INCLUDE_DIR}
${GLIBCONFIG_INCLUDE_DIR}
Expand All @@ -219,11 +191,6 @@ else (GLIB2_LIBRARIES AND GLIB2_INCLUDE_DIRS)
set(GLIB2_INCLUDE_DIRS ${GLIB2_INCLUDE_DIRS} ${LIBINTL_INCLUDE_DIR})
endif (LIBINTL_FOUND)

if (LIBICONV_FOUND)
set(GLIB2_LIBRARIES ${GLIB2_LIBRARIES} ${LIBICONV_LIBRARY})
set(GLIB2_INCLUDE_DIRS ${GLIB2_INCLUDE_DIRS} ${LIBICONV_INCLUDE_DIR})
endif (LIBICONV_FOUND)

if (GLIB2_INCLUDE_DIRS AND GLIB2_LIBRARIES)
set(GLIB2_FOUND TRUE)
endif (GLIB2_INCLUDE_DIRS AND GLIB2_LIBRARIES)
Expand Down
6 changes: 0 additions & 6 deletions cmakeconfig.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
/* Define to use heimdal kerberos */
#cmakedefine HAVE_HEIMDAL_KERBEROS 1

/* Define if you have the iconv() function. */
#cmakedefine HAVE_ICONV 1

/* Define if inet_ntop() prototype exists */
#cmakedefine HAVE_INET_NTOP_PROTO 1

Expand Down Expand Up @@ -227,9 +224,6 @@
/* HTML viewer, e.g. mozilla */
#cmakedefine HTML_VIEWER

/* Define as const if the declaration of iconv() needs const. */
#cmakedefine ICONV_CONST 1

/* Define if <inttypes.h> defines PRI[doxu]64 macros */
/* Note: always defines PRI[doxu]64 macros so inttypes.h becomes useless.*/
#cmakedefine INTTYPES_H_DEFINES_FORMATS 1
Expand Down
3 changes: 0 additions & 3 deletions configure.in
Original file line number Diff line number Diff line change
Expand Up @@ -1129,9 +1129,6 @@ AC_CHECK_HEADERS(sys/ioctl.h sys/param.h sys/socket.h sys/sockio.h sys/stat.h sy
AC_CHECK_HEADERS(netinet/in.h)
AC_CHECK_HEADERS(arpa/inet.h arpa/nameser.h)

dnl iconv check
AM_ICONV

dnl SSL Check
SSL_LIBS=''
AC_MSG_CHECKING(whether to use SSL library)
Expand Down
2 changes: 1 addition & 1 deletion epan/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ libwireshark_la_LIBADD = \
dfilter/libdfilter.la dissectors/libcleandissectors.la \
dissectors/libdissectors.la dissectors/libasndissectors.la \
dissectors/libpidldissectors.la $(wslua_lib) @SOCKET_LIBS@ @NSL_LIBS@ \
@ADNS_LIBS@ @LIBGCRYPT_LIBS@ @LIBGNUTLS_LIBS@ @LIBICONV@ @KRB5_LIBS@ \
@ADNS_LIBS@ @LIBGCRYPT_LIBS@ @LIBGNUTLS_LIBS@ @KRB5_LIBS@ \
@SSL_LIBS@ @LIBSMI_LDFLAGS@ -lm
libwireshark_la_DEPENDENCIES = \
@INET_ATON_LO@ @INET_PTON_LO@ @INET_NTOP_LO@ libwireshark_generated.la \
Expand Down

0 comments on commit 86e1088

Please sign in to comment.