Repository navigation
ci: use rpm-build find-requires for RPM auto-req - #61
Merged
Merged
Conversation
The cargo-generate-rpm built-in ldd-based auto-req emits glibc requires with a "[WEAK]" suffix that EL8's dnf cannot resolve, breaking the test-collector-rpm job at install time. Install rpm-build in the build container and pass --auto-req find-requires so dependency discovery uses rpm-build's own find-requires script, which emits requires dnf can resolve. Also log the built RPM's requires in the test job before installing it, to make future dependency issues easier to diagnose.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed CI changes address EL8 dependency resolution and add useful diagnostics.
Review effort: Lite
Findings: None
What changed in this PR
Updates RPM CI packaging for EL8 compatibility by using rpm-build’s find-requires dependency discovery.
Changes:
- Installs
rpm-buildin the RPM build container. - Uses
--auto-req find-requires. - Logs RPM requirements before installation.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Updates RPM build dependencies, packaging options, and diagnostics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rodonile
marked this pull request as ready for review
October 2, 2026 13:18
rodonile
enabled auto-merge (rebase)
October 2, 2026 13:22
rodonile
disabled auto-merge
October 2, 2026 13:22
rodonile
enabled auto-merge (rebase)
October 2, 2026 13:22
riccardo-negri
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RPM package generation for EL8 by switching automatic dependency discovery from cargo-generate-rpm's built-in ldd-based mode to rpm-build's
find-requiresscript.Reason
The built-in auto-req emits glibc requires with a
[WEAK]suffix that EL8'sdnfcannot resolve, causing thetest-collector-rpmjob to fail when installing the built RPM.Changelog
rpm-buildin thebuild-collector-rpmcontainer (provides/usr/lib/rpm/find-requires).--auto-req find-requirestocargo generate-rpm.rpm -qpR) in the test job before install, to ease future dependency debugging.