Skip to content

Conversation

@SunDevil311
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added

  • Introduced Branch Guard workflow (.github/workflows/branch-guard.yml) to automatically enforce branch protection policies.
    • Ensures consistent branch naming conventions.
    • Blocks direct pushes to protected branches (e.g., master, main, and release/*).
    • Provides early validation for pull requests and feature branches to maintain repository integrity.
  • Introduced comprehensive pre-push checks for code consistency and style compliance.
    • Added optional simple-git-hooks configuration to automate local linting before commits or pushes.
    • Implemented lint:all script using npm-run-all for efficient, parallel execution of linters.
    • Ensures ESLint, Stylelint, Markdownlint, and Prettier all run before code is committed, improving codebase hygiene and preventing formatting drift.
    • Designed for developer-side speed and reliability, running linters in parallel while deferring format (Prettier) until after lint checks complete for safety.
  • Added hybrid linting configuration:
    • Parallel execution for static lint tasks (eslint, stylelint, markdownlint).
    • Sequential Prettier formatting step for deterministic, race-free execution.

Changed

  • Reorganized local linting commands for clarity and consistency, consolidating redundant sequential scripts into the lint:all aggregator.
  • Improved developer experience with faster pre-push validations and clearer script naming conventions.
  • Bumped project version to v1.24.5.

Developer Experience

  • Enhanced local development workflow by introducing fast, parallel linting and optional pre-commit hooks, reducing turnaround time for style and quality checks.
  • Simplified npm scripts for readability and maintainability by adopting npm-run-all as the central task runner.

Notes

  • For instructions on installing and configuring the new dependencies, please see the Editor Configuration section of the Wiki.

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked for existing Pull Requests for the same update/change.
  • My code follows the project’s coding style.
  • My code has been linted locally before submission.
  • All new and existing tests pass.

 

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, if applicable. (Optional, especially for new contributors)

Pull requests are part of a collaborative process — we welcome contributions and review each one carefully. For all but the smallest changes, you can expect maintainers to request improvements or clarifications.

Please check back after opening your PR and be responsive to feedback so we can get your contribution merged quickly.

Thanks for helping improve Network Pro Strategies!

@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
audit Ready Ready Preview Comment Nov 3, 2025 1:29am
web Ready Ready Preview Comment Nov 3, 2025 1:29am

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.9)
  • Largest Contentful Paint (score: 0.85)
  • Speed Index (score: 0.97)
  • Total Blocking Time (score: 0.34)
  • Max Potential First Input Delay (score: 0.02)
  • Time to Interactive (score: 0.85)
  • Minimize main-thread work (score: 0)
  • Reduce JavaScript execution time (score: 0)
  • Largest Contentful Paint element (score: 0)
  • Links rely on color to be distinguishable. (score: 0)
  • Serve static assets with an efficient cache policy (score: 0.5)
  • Reduce unused CSS (score: 0)
  • Reduce unused JavaScript (score: 0.5)
  • Avoid serving legacy JavaScript to modern browsers (score: 0.5)
  • Use efficient cache lifetimes (score: 0.5)
  • Document request latency (score: 0)
  • Optimize DOM size (score: 0)
  • Duplicated JavaScript (score: 0.5)
  • Legacy JavaScript (score: 0.5)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Merging upon successful completion of tests.

@vercel vercel bot temporarily deployed to Preview – audit November 3, 2025 01:28 Inactive
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.94)
  • Largest Contentful Paint (score: 0.85)
  • Speed Index (score: 0.98)
  • Total Blocking Time (score: 0.7)
  • Max Potential First Input Delay (score: 0.09)
  • Time to Interactive (score: 0.89)
  • Minimize main-thread work (score: 0)
  • Largest Contentful Paint element (score: 0)
  • Links rely on color to be distinguishable. (score: 0)
  • Serve static assets with an efficient cache policy (score: 0.5)
  • Reduce unused CSS (score: 0)
  • Reduce unused JavaScript (score: 0.5)
  • Avoid serving legacy JavaScript to modern browsers (score: 0.5)
  • Use efficient cache lifetimes (score: 0.5)
  • Document request latency (score: 0)
  • Duplicated JavaScript (score: 0.5)
  • Legacy JavaScript (score: 0.5)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed look good.

@SunDevil311 SunDevil311 merged commit 4b1695e into master Nov 3, 2025
12 checks passed
@SunDevil311 SunDevil311 deleted the feature/bguard-and-scripts branch November 3, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants