Skip to content

Conversation

@SunDevil311
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added

  • Introduced dynamic QR code image imports using import.meta.glob in src/lib/images.js.
  • Implemented new getQR() helper function for streamlined QR lookups.
  • Added QR_IMAGES registry for centralized QR asset management.
  • Created dedicated PGP key data module (src/lib/data/pgpKeys.js) with dynamic QR bindings.
  • Added new app constants (EMAIL_LINK, SECURE_LINK, PRIVACY_LINK) to:
    • src/lib/index.js
    • src/lib/types/appConstants.js
  • Re-exported src/lib/data/pgpKeys.js from src/lib/index.js.
  • Added favicon and manifest entry for icon-about.png.
  • Introduced updated contact assets block in AboutContent.svelte with enhanced typing.
  • Exported src/lib/img/powered-by-proton.svg from src/lib/images.js.
  • Added missing JSDoc annotation to src/lib/data/fossData.js.
  • Added updated PGP key for support@netwk.pro (previously support@neteng.pro).

Changed

  • Bumped project version to v1.22.0.
  • Updated generator metadata in src/app.html to reflect SvelteKit 2.47.2.
  • Refactored PGPContent.svelte to use the getQR() helper and dynamic QR registry.
  • Refactored AboutContent.svelte to use the centralized PGP_KEYS dataset and app constants.
  • Split PGP key fingerprints into two lines for improved readability.
  • Enhanced images.js with support for eager QR image imports.
  • Replaced static PGP imports with automated dynamic resolution.
  • Updated manifest.json to reference the new app icon.
  • Revised layout and text consistency for PGP and contact sections in AboutContent.svelte.
  • Updated type definitions in src/lib/types/appConstants.js for CONTACT constants.
  • Cleaned up unused imports and improved inline JSDoc typings throughout the app.
  • Updated asset references in IGNORE_PATHS and REQUIRED_ASSETS in src/service-worker.js.
  • Added spacing adjustments to the tagline in Logo.svelte.
  • Updated HeaderDefault.svelte to reference the global constant for the Blog link.
  • Revised text and app constant usage in HomeContent.svelte.
  • Updated the contact section and Effective Date in ServicesContent.svelte.
  • Rebuilt src/lib/styles/global.min.css using LightningCSS.
  • Refreshed _Last Modified_ timestamps in static/sitemap.xml.

Fixed

  • Fixed SSR error caused by missing getQR reference during page load.
  • Corrected destructuring of CONTACT constants during SSR initialization.
  • Fixed fingerprint rendering fallback when fingerprint type was non-array.
  • Adjusted QR image alignment and eager/lazy decoding behavior.

Removed

  • Deleted outdated static assets from static/pgp, replaced with dynamically loaded QR images.
  • Removed redundant manual image imports from legacy sections of images.js.
  • Removed unnecessary comment block from the <head> section of src/app.html.
  • Removed font-weight: bold property from the .fingerprint CSS class in src/lib/styles/css/default.css.

🧩 Technical Notes

  • Updated vite from v7.1.10v7.1.11 to address CVE-2025-62522.
  • Updated dependencies for SvelteKit 2.47.2 compatibility:
    • @sveltejs/kit, svelte, vite, and eslint-related plugins.
  • Cleaned up build cache and service worker registration logic in src/service-worker.js.

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked for existing Pull Requests for the same update/change.
  • My code follows the project’s coding style.
  • My code has been linted locally before submission.
  • All new and existing tests pass.

 

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, if applicable. (Optional, especially for new contributors)

Pull requests are part of a collaborative process — we welcome contributions and review each one carefully. For all but the smallest changes, you can expect maintainers to request improvements or clarifications.

Please check back after opening your PR and be responsive to feedback so we can get your contribution merged quickly.

Thanks for helping improve Network Pro Strategies!

@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Oct 21, 2025 6:47am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@github-actions
Copy link

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.96)
  • Largest Contentful Paint (score: 0.37)
  • Time to Interactive (score: 0.82)
  • Avoid multiple page redirects (score: 0)
  • Largest Contentful Paint element (score: 0)
  • Links rely on color to be distinguishable. (score: 0)
  • Serve static assets with an efficient cache policy (score: 0.5)
  • Reduce unused JavaScript (score: 0)
  • Avoid serving legacy JavaScript to modern browsers (score: 0.5)
  • Use efficient cache lifetimes (score: 0.5)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

@github-actions
Copy link

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.8)
  • Largest Contentful Paint (score: 0.36)
  • Speed Index (score: 0.99)
  • Time to Interactive (score: 0.81)
  • Avoid multiple page redirects (score: 0)
  • Largest Contentful Paint element (score: 0)
  • Links rely on color to be distinguishable. (score: 0)
  • Serve static assets with an efficient cache policy (score: 0.5)
  • Reduce unused JavaScript (score: 0)
  • Avoid serving legacy JavaScript to modern browsers (score: 0)
  • Use efficient cache lifetimes (score: 0.5)
  • Duplicated JavaScript (score: 0.5)
  • Legacy JavaScript (score: 0.5)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Merging upon successful completion of tests.

@SunDevil311 SunDevil311 merged commit 83ad3e3 into master Oct 21, 2025
10 checks passed
@SunDevil311 SunDevil311 deleted the fix/update-vite branch October 21, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants