Skip to content

Conversation

@SunDevil311
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added

  • Introduced modular analytics initializer at src/lib/utils/initAnalytics.js to handle PostHog tracking, asset preloading, and cleanup logic.

Changed

  • Bumped project version to v1.21.0.
  • Added pageleave to cspell.json to support custom PostHog events.
  • Expanded lint script in package.json to include .cjs files.
  • Updated src/service-worker.js to correctly exclude security.txt.sig from caching.
  • Refactored +layout.svelte to use the new initAnalytics.js utility for cleaner side-effect management.
  • Updated fallback meta description logic in both +layout.svelte and +layout.js.
  • Adjusted "purpose" value in static/manifest.json from "any maskable" to "maskable" for improved PWA icon support.
  • Increased spacing before contact info in src/lib/pages/HomeContent.svelte.
  • Enhanced registerServiceWorker.js to skip SW registration in Firefox during development, preventing known /@fs/ path evaluation errors.
  • Integrated automatic cleanup of existing service workers in registerServiceWorker.js when running in Firefox + dev mode.
  • Improved logging clarity in registerServiceWorker.js to better distinguish SW lifecycle behavior by environment.
  • Updated unregisterServiceWorker.js to include scoped SW logging when unregistering.
  • Refactored posthog.js to add conditional guards for suppressing noisy analytics errors in development mode.

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked for existing Pull Requests for the same update/change.
  • My code follows the project’s coding style.
  • My code has been linted locally before submission.
  • All new and existing tests pass.

 

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, if applicable. (Optional, especially for new contributors)

Pull requests are part of a collaborative process — we welcome contributions and review each one carefully. For all but the smallest changes, you can expect maintainers to request improvements or clarifications.

Please check back after opening your PR and be responsive to feedback so we can get your contribution merged quickly.

Thanks for helping improve Network Pro Strategies!

@vercel
Copy link

vercel bot commented Oct 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Oct 18, 2025 2:02am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@github-actions
Copy link

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.36)
  • Largest Contentful Paint (score: 0.64)
  • Speed Index (score: 0.79)
  • Total Blocking Time (score: 0.02)
  • Max Potential First Input Delay (score: 0)
  • Time to Interactive (score: 0.43)
  • Minimize main-thread work (score: 0)
  • Reduce JavaScript execution time (score: 0)
  • Largest Contentful Paint element (score: 0)
  • Links rely on color to be distinguishable. (score: 0)
  • Serve static assets with an efficient cache policy (score: 0.5)
  • Reduce unused CSS (score: 0.5)
  • Reduce unused JavaScript (score: 0.5)
  • Avoid serving legacy JavaScript to modern browsers (score: 0.5)
  • Use efficient cache lifetimes (score: 0.5)
  • Optimize DOM size (score: 0)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Merging upon successful completion of tests.

@SunDevil311 SunDevil311 merged commit 3d6005a into master Oct 18, 2025
10 checks passed
@SunDevil311 SunDevil311 deleted the feature/modular-analytics branch October 18, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants