This repository was archived by the owner on Apr 3, 2025. It is now read-only.
Catch completion handler errors #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We need to catch exceptions from event completions, like epoll and kqueue does. Otherwise the exceptions can propagate to the event loop thread and kill it. This makes it appear stuck or shut down. Modification: Catch and log exceptions thrown by IOUringEventLoop.handle. Result: The event loop should not get stuck or shut down when a completion event throws an exception.
normanmaurer
approved these changes
Apr 24, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to catch exceptions from event completions, like epoll and kqueue does. Otherwise the exceptions can propagate to the event loop thread and kill it. This makes it appear stuck or shut down.
Modification:
Catch and log exceptions thrown by IOUringEventLoop.handle.
Result:
The event loop should not get stuck or shut down when a completion event throws an exception.