feat(core-jpa): BaseEntity 추상 클래스 분리 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UuidBaseEntity 클래스 추가 - BaseEntity -> LongBaseEntity 클래스명 변경 Refs #28
silberbullet
requested review from
merge-simpson,
sweetykr7,
taewookimm,
jilpoom,
silberbullet,
wch-os,
github-insu and
shin-jingyu
and removed request for
merge-simpson and
sweetykr7
silberbullet
requested changes
Feb 17, 2025
There was a problem hiding this comment.
@Ropung 님 작업하시느라 고생하셨습니다.
다만 UuidBaseEntity.java에 수정 사항이 있습니다!
merge-simpson
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
👍 빠른 작업 감사합니다.
바쁘신 중에도 빠르게 게시해 주셔서 검토가 수월했습니다.
사소하게 발견된 작업 사항은,
바쁘시다 보면 누락되기 쉬운 항목들인 만큼
이렇게 서로 검토하는 시간이 더 유익할 수 있는 것 같습니다.
@Ropung 님께서 앞으로도 참여 가능하신 작업들에는 즉석에서 하나씩 참여해 주시면 든든할 것 같습니다!
저는 이대로 병합을 진행해 주셔도 좋아 보입니다.
(다른 리뷰자가 수정을 요청한 부분 및 관련 부분만 수정해 주세요!)
| 🚀 | 🏅 Approve! |
src/main/java/me/nettee/board/adapter/driven/persistence/entity/BoardEntityLong.java
Outdated
Show resolved
Hide resolved
merge-simpson
added
in: board
silberbullet
approved these changes
Feb 18, 2025
| @MappedSuperclass | ||
| public abstract class UuidBaseEntity implements Serializable { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.UUID) |
There was a problem hiding this comment.
UUID 타입을 적용 후, UUID 자동 채번 설정을 하였습니다!
| import java.time.Instant; | ||
|
|
||
| @Getter | ||
| @MappedSuperclass | ||
| @EntityListeners(AuditingEntityListener.class) | ||
| public abstract class BaseTimeEntity extends BaseEntity { | ||
| public abstract class BaseTimeEntity implements Serializable { |
There was a problem hiding this comment.
BaseTimeEntity는 개발자가 직접 인스턴스를 생성을 방지하도록 추상 클래스로 바꾸었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #28
Pull Request
Issues
Resolves #28
Description
How Has This Been Tested?
Additional Notes